On Tue, Jul 28, 2015 at 01:55:23PM +0300, Yaron Keren wrote: > +cfe-commits > > This is a very large Solaris special case in ScanLibDirForGCCTriple which > shares almost no code with the function. > How about splitting it out to a helper function or > making ScanLibDirForGCCTriple virtual and overriding on Solaris?
Yep, at least a helper function makes sense, you are right. I'll send another patch with either of those suggestions later today. Xan _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
