On 17/08/2009, at 21.15, Eli Friedman wrote:
> On Mon, Aug 17, 2009 at 12:05 PM, Jakob Stoklund Olesen<[email protected]
> > wrote:
> + virtual const char *getClobbers() const {
> + return "";
> + }
>
> You might want to double-check this... usually inline asm at least
> clobbers the flag register, and IIRC Blackfin has one.
Hmm. Yes, there is an astat register that is clobbered by arithmetic
instructions. On the other hand, many instructions don't touch it,
including pointer arithmetic.
I think I'll prefer to keep it blank. Most of the inline asm I have
written would not clobber astat. You don't usually need inline asm for
arithmetic.
> + virtual const char *getVAListDeclaration() const {
> + // FIXME: implement
> + return "typedef char* __builtin_va_list;";
> + }
> + };
>
> What's the FIXME about?
It's a pasto. The typedef is fine for Blackfin. I'll remove it.
> Otherwise, looks good.
Thanks for reviewing.
/jakob
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
