Argyrios Kyrtzidis wrote: > On Aug 20, 2009, at 2:03 AM, Sebastian Redl wrote: > >> Argiris Kirtzidis wrote: >>> Author: akirtzidis >>> Date: Wed Aug 19 18:14:54 2009 >>> New Revision: 79489 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=79489&view=rev >>> Log: >>> Keep track of the right paren ')' source location in a function >>> declarator. >>> >> This comment is slightly in conflict with the content of the patch, >> which (judging from the variable names) wants to keep track of the end >> of the declarator. For C++, this might not be the right paren (exception >> specs, function cv-qualifiers, and in C++0x ref-qualifiers get in the >> way). >> >> What is the actual intent of the patch? > > The end of the declarator was already kept in track, it was the > variable "SourceLocation Loc;" > The right paren was not, so I added a variable for the right paren, > and renamed Loc -> EndLoc to make the code more readable. Ah, that makes sense. Didn't look carefully enough. Thanks for the clarification.
Sebastian _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
