Author: ddunbar
Date: Wed Sep 16 23:01:40 2009
New Revision: 82118
URL: http://llvm.org/viewvc/llvm-project?rev=82118&view=rev
Log:
IRgen/ObjC: Correctly construct the function info for variadic message sends.
This fixes some bad -O0 codegen and the unnecessary clearing of al on entry to
objc_msgSend for most message sends.
<rdar://problem/7102824> [irgen] unnecessary xorb on calls to objc_msgSend on
x86_64
Added:
cfe/trunk/test/CodeGenObjC/variadic-sends.m
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCGNU.cpp?rev=82118&r1=82117&r2=82118&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGObjCGNU.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGObjCGNU.cpp Wed Sep 16 23:01:40 2009
@@ -380,7 +380,8 @@
CodeGenTypes &Types = CGM.getTypes();
const CGFunctionInfo &FnInfo = Types.getFunctionInfo(ResultType, ActualArgs);
- const llvm::FunctionType *impType = Types.GetFunctionType(FnInfo, false);
+ const llvm::FunctionType *impType =
+ Types.GetFunctionType(FnInfo, Method ? Method->isVariadic() : false);
llvm::Value *ReceiverClass = 0;
if (isCategoryImpl) {
@@ -478,7 +479,8 @@
CodeGenTypes &Types = CGM.getTypes();
const CGFunctionInfo &FnInfo = Types.getFunctionInfo(ResultType, ActualArgs);
- const llvm::FunctionType *impType = Types.GetFunctionType(FnInfo, false);
+ const llvm::FunctionType *impType =
+ Types.GetFunctionType(FnInfo, Method ? Method->isVariadic() : false);
llvm::Value *imp;
// For sender-aware dispatch, we pass the sender as the third argument to a
Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=82118&r1=82117&r2=82118&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Wed Sep 16 23:01:40 2009
@@ -1530,9 +1530,8 @@
CodeGenTypes &Types = CGM.getTypes();
const CGFunctionInfo &FnInfo = Types.getFunctionInfo(ResultType, ActualArgs);
- // In 64bit ABI, type must be assumed VARARG. In 32bit abi,
- // it seems not to matter.
- const llvm::FunctionType *FTy = Types.GetFunctionType(FnInfo, (ObjCABI ==
2));
+ const llvm::FunctionType *FTy =
+ Types.GetFunctionType(FnInfo, Method ? Method->isVariadic() : false);
llvm::Constant *Fn = NULL;
if (CGM.ReturnTypeUsesSret(FnInfo)) {
Added: cfe/trunk/test/CodeGenObjC/variadic-sends.m
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/variadic-sends.m?rev=82118&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenObjC/variadic-sends.m (added)
+++ cfe/trunk/test/CodeGenObjC/variadic-sends.m Wed Sep 16 23:01:40 2009
@@ -0,0 +1,41 @@
+// RUN: clang-cc -triple i386-unknown-unknown -fnext-runtime -emit-llvm -o -
%s | FileCheck -check-prefix=CHECK-X86-32 %s &&
+// RUN: clang-cc -triple x86_64-unknown-unknown -fnext-runtime -emit-llvm -o -
%s | FileCheck -check-prefix=CHECK-X86-64 %s
+
+...@interface A
+-(void) im0;
+-(void) im1: (int) x;
+-(void) im2: (int) x, ...;
+...@end
+
+void f0(A *a) {
+ // CHECK-X86-32: call void bitcast (i8* (i8*, %struct.objc_selector*, ...)*
@objc_msgSend to void (i8*, %struct.objc_selector*)*)
+ // CHECK-X86-64: call void bitcast (i8* (i8*, %struct.objc_selector*, ...)*
@objc_msgSend to void (i64, %struct.objc_selector*)*)
+ [a im0];
+}
+
+void f1(A *a) {
+ // CHECK-X86-32: call void bitcast (i8* (i8*, %struct.objc_selector*, ...)*
@objc_msgSend to void (i8*, %struct.objc_selector*, i32)*)
+ // CHECK-X86-64: call void bitcast (i8* (i8*, %struct.objc_selector*, ...)*
@objc_msgSend to void (i64, %struct.objc_selector*, i32)*)
+ [a im1: 1];
+}
+
+void f2(A *a) {
+ // CHECK-X86-32: call void (i8*, %struct.objc_selector*, i32, i32, ...)*
bitcast (i8* (i8*, %struct.objc_selector*, ...)* @objc_msgSend to void (i8*,
%struct.objc_selector*, i32, i32, ...)*)
+ // CHECK-X86-64: call void (i64, %struct.objc_selector*, i32, i32, ...)*
bitcast (i8* (i8*, %struct.objc_selector*, ...)* @objc_msgSend to void (i64,
%struct.objc_selector*, i32, i32, ...)*)
+ [a im2: 1, 2];
+}
+
+...@interface B : A @end
+...@implementation B : A
+-(void) foo {
+ // CHECK-X86-32: call void bitcast (i8* (%struct._objc_super*,
%struct.objc_selector*, ...)* @objc_msgSendSuper to void (%struct._objc_super*,
%struct.objc_selector*, i32)*)
+ // CHECK-X86-64: call void bitcast (i8* (%struct._objc_super*,
%struct.objc_selector*, ...)* @objc_msgSendSuper to void (%struct._objc_super*,
%struct.objc_selector*, i32)*)
+ [super im1: 1];
+}
+-(void) bar {
+ // CHECK-X86-32: call void (%struct._objc_super*, %struct.objc_selector*,
i32, i32, ...)* bitcast (i8* (%struct._objc_super*, %struct.objc_selector*,
...)* @objc_msgSendSuper to void (%struct._objc_super*, %struct.objc_selector*,
i32, i32, ...)*)
+ // CHECK-X86-64: call void (%struct._objc_super*, %struct.objc_selector*,
i32, i32, ...)* bitcast (i8* (%struct._objc_super*, %struct.objc_selector*,
...)* @objc_msgSendSuper to void (%struct._objc_super*, %struct.objc_selector*,
i32, i32, ...)*)
+ [super im2: 1, 2];
+}
+
+...@end
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
