Hi Devang, On Mon, Oct 12, 2009 at 4:46 PM, Devang Patel <[email protected]> wrote: > Author: dpatel > Date: Mon Oct 12 18:46:58 2009 > New Revision: 83929 > > URL: http://llvm.org/viewvc/llvm-project?rev=83929&view=rev > Log: > Disable tests that check debug info intrinsic. This does not work if debug > info intrinsics are not used to encode debug info.
This is inappropriate, I think. Unless you plan on bringing debug info intrinsics back, then these tests should be updated not XFAILed. - Daniel > Modified: > cfe/trunk/test/CodeGen/blocks-2.c > cfe/trunk/test/CodeGenObjC/PR4894-recursive-debug-crash.m > > Modified: cfe/trunk/test/CodeGen/blocks-2.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/blocks-2.c?rev=83929&r1=83928&r2=83929&view=diff > > ============================================================================== > --- cfe/trunk/test/CodeGen/blocks-2.c (original) > +++ cfe/trunk/test/CodeGen/blocks-2.c Mon Oct 12 18:46:58 2009 > @@ -1,6 +1,7 @@ > // RUN: clang-cc -g %s -emit-llvm -o %t -fblocks && > // RUN: grep "func.start" %t | count 4 > // 1 declaration, 1 bar, 1 test_block_dbg and 1 for the block. > +// XFAIL > > static __inline__ __attribute__((always_inline)) int bar(int va, int vb) { > return (va == vb); } > > > Modified: cfe/trunk/test/CodeGenObjC/PR4894-recursive-debug-crash.m > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/PR4894-recursive-debug-crash.m?rev=83929&r1=83928&r2=83929&view=diff > > ============================================================================== > --- cfe/trunk/test/CodeGenObjC/PR4894-recursive-debug-crash.m (original) > +++ cfe/trunk/test/CodeGenObjC/PR4894-recursive-debug-crash.m Mon Oct 12 > 18:46:58 2009 > @@ -3,6 +3,7 @@ > // > // This test is actually just making sure we can generate the debug info for > the > // return type from im0 without crashing. > +// XFAIL > > �...@interface I0 { > I0 *_iv0; > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
