On Nov 4, 2009, at 1:53 PM, John Thompson wrote:

Here's another go at it, adding stuff for PCH and the driver. I put in a partial test of the driver change in test/Driver/ clang_f_opts.c, which I hope is an appropriate place.

Looks good, but could you address this comment



The change to the wchar.c test allows it to pass on Windows (and still pass on Linux, which defaults to int for wchar_t).

I'd like to retain the test that we use "int" for the other targets. Could you do something like

RUN: clang-cc %s -fsyntax-only -triple i686-pc-linux-gnu -verify - DWCHAR_T_TYPE="int" && RUN: clang-cc %s -fsyntax-only -fshort-wchar -verify - DWCHAR_T_TYPE="unsigned short"

then use WCHAR_T_TYPE as the element type of the t1 and t2 arrays?

       - Doug

before committing?

        - Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to