Oh, shall I revert it? I just think it's less orthogonal. 2009/11/20 Ted Kremenek <[email protected]>: > Hi Zhongxing, > > That was a slight performance tweak. Basically there is no need to run > Checkers on that location if it is unknown. > > On Nov 19, 2009, at 5:56 PM, Zhongxing Xu wrote: > >> Author: zhongxingxu >> Date: Thu Nov 19 19:56:48 2009 >> New Revision: 89437 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=89437&view=rev >> Log: >> It's unnecessary to check for unknown at this point. >> >> Modified: >> cfe/trunk/lib/Analysis/GRExprEngine.cpp >> >> Modified: cfe/trunk/lib/Analysis/GRExprEngine.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngine.cpp?rev=89437&r1=89436&r2=89437&view=diff >> >> ============================================================================== >> --- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original) >> +++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Thu Nov 19 19:56:48 2009 >> @@ -1278,8 +1278,7 @@ >> ExplodedNode* Pred, >> const GRState* state, SVal location, >> const void *tag, bool isLoad) { >> - >> - if (location.isUnknown() || Checkers.empty()) { >> + if (Checkers.empty()) { >> Dst.Add(Pred); >> return; >> } >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
