On Mon, Dec 14, 2009 at 11:30 PM, Chris Lattner <[email protected]> wrote: > Author: lattner > Date: Tue Dec 15 01:30:12 2009 > New Revision: 91424 > > URL: http://llvm.org/viewvc/llvm-project?rev=91424&view=rev > Log: > move isPodLike<clang::QualType> out to Type.h. We don't > want some clients of QualType to think it's a pod and some to > not know it is.
Why not? Wouldn't that lead to lots of fun problems? - Daniel > Modified: > cfe/trunk/include/clang/AST/Type.h > cfe/trunk/include/clang/AST/TypeOrdering.h > > Modified: cfe/trunk/include/clang/AST/Type.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Type.h?rev=91424&r1=91423&r2=91424&view=diff > > ============================================================================== > --- cfe/trunk/include/clang/AST/Type.h (original) > +++ cfe/trunk/include/clang/AST/Type.h Tue Dec 15 01:30:12 2009 > @@ -35,7 +35,9 @@ > TypeAlignmentInBits = 3, > TypeAlignment = 1 << TypeAlignmentInBits > }; > - class Type; class ExtQuals; > + class Type; > + class ExtQuals; > + class QualType; > } > > namespace llvm { > @@ -59,6 +61,9 @@ > } > enum { NumLowBitsAvailable = clang::TypeAlignmentInBits }; > }; > + > + template <> > + struct isPodLike<clang::QualType> { static const bool value = true; }; > } > > namespace clang { > > Modified: cfe/trunk/include/clang/AST/TypeOrdering.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TypeOrdering.h?rev=91424&r1=91423&r2=91424&view=diff > > ============================================================================== > --- cfe/trunk/include/clang/AST/TypeOrdering.h (original) > +++ cfe/trunk/include/clang/AST/TypeOrdering.h Tue Dec 15 01:30:12 2009 > @@ -51,10 +51,6 @@ > return LHS == RHS; > } > }; > - > - // FIXME: Move to Type.h > - template <> > - struct isPodLike<clang::QualType> { static const bool value = true; }; > } > > #endif > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
