On Jan 4, 2010, at 11:08 AM, Ken Dyck wrote:

> 
> The attached patches replace occurrences of ASTContext::getTypeSize()/8
> with ASTContext::getTypeSizeInChars(),  converting [u]int64_t variables
> to CharUnits ones where it seems appropriate. No functional changes are
> intended. The changes touch the AST, Analysis, Sema, and CodeGen
> libraries and are split into patches accordingly.

Sorry for the delay, this code looks great to me.  The only thing that I don't 
like is the name 'getRaw()'.  How about just 'getValue()' or getAmount()?

-Chris
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to