Hi, Chris

> +    d->addAttr(::new (S.Context) MSP430InterruptAttr(Num));
> +    d->addAttr(::new (S.Context) NoInlineAttr());
> +    d->addAttr(::new (S.Context) UsedAttr());
> 
> It seems that you should only add the MSP430InterruptAttr attribute to the 
> decl,
> but that codegen should add the other attributes to the LLVM IR function.
> Is there a reason to add noinline and used to the AST?
There is no reason for noinline, I agree, since it's just a function
attribute. Used is quite different, since it requires special codegen
support and I don't want to reinvent the wheel.

So, basically, I will move noinline to codegen part, but keep used here.

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to