20 jan 2010 kl. 19.33 skrev Sean Hunt:
> On 01/10/2010 10:20 AM, Anders Carlsson wrote:
>> Sure! (I'm on vacation this week but I'll try to find some time :)
>>
>> Anders
>>
>> 8 jan 2010 kl. 10.45 skrev Chris Lattner:
>>
>>> On Jan 7, 2010, at 12:52 AM, Sean Hunt wrote:
>>>> This patch fixes http://llvm.org/bugs/show_bug.cgi?id=5966 by making the
>>>> same changes to clang made to fix
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31775
>>>
>>> Anders, can you review this mangling patch when you get a chance?
>>>
>>> -Chris
>>
>
> Ping?
>
Patch looks good! Two minor comments:
I think you can put the test case in mangle.cpp, just put it inside its own
namespace:
// PR5966
namespace PR5966 {
}
> + ND->getDeclContext()->isFileContext())
> + Out << "L";
Can just use 'L' here instead.
Thanks for fixing this!
Anders
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits