On Jan 22, 2010, at 12:53 PM, Mike Stump wrote: > On Jan 22, 2010, at 12:39 PM, Chris Lattner wrote: >> Thanks for improving this area. However, please either switch >> virt.cpp to use -emit-llvm (or some other way of verifying the >> output) or start adding new testcases to a virt2.cpp that doesn't >> grep the .s file. Continuing to make virt.cpp worse is not good. > > Having the .s file for wrong testcases and how they are wrong is > very handy. Let me counter propose converting the parts that test > out ok enmass over the testing the .ll file, and working on fixing > those entires that don't work yet, so they do, and converting them > over as they are fixed. Sound reasonable?
I'm not sure exactly what you're proposing. The bad thing about this is that it is grepping the x86-64 .s file output. It should grep the .ll file output, or you should add a debug mode to the vtable layout stuff and grep the output of that. -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
