I am in favor of removing them. -Chris
On Feb 9, 2010, at 12:22 AM, Daniel Dunbar <[email protected]> wrote: > Author: ddunbar > Date: Tue Feb 9 02:22:03 2010 > New Revision: 95658 > > URL: http://llvm.org/viewvc/llvm-project?rev=95658&view=rev > Log: > Update tests in -Asserts mode. These tests really need to be > rewritten... > > Modified: > cfe/trunk/test/CodeGenCXX/condition.cpp > cfe/trunk/test/CodeGenCXX/virt.cpp > > Modified: cfe/trunk/test/CodeGenCXX/condition.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/condition.cpp?rev=95658&r1=95657&r2=95658&view=diff > > === > === > === > ===================================================================== > --- cfe/trunk/test/CodeGenCXX/condition.cpp (original) > +++ cfe/trunk/test/CodeGenCXX/condition.cpp Tue Feb 9 02:22:03 2010 > @@ -64,7 +64,7 @@ > z = 19; > break; > } > - // CHECK: {{sw.epilog:|:4}} > + // CHECK: {{sw.epilog:|:5}} > // CHECK: call void @_ZN16ConvertibleToIntD1Ev > // CHECK: store i32 20 > z = 20; > @@ -74,18 +74,18 @@ > > void while_destruct(int z) { > // CHECK: define void @_Z14while_destructi > - // CHECK: {{while.cond:|:1}} > + // CHECK: {{while.cond:|:2}} > while (X x = X()) { > // CHECK: call void @_ZN1XC1Ev > > - // CHECK: {{while.body:|:3}} > + // CHECK: {{while.body:|:4}} > // CHECK: store i32 21 > z = 21; > > - // CHECK: {{while.cleanup:|:4}} > + // CHECK: {{while.cleanup:|:5}} > // CHECK: call void @_ZN1XD1Ev > } > - // CHECK: {{while.end|:6}} > + // CHECK: {{while.end|:7}} > // CHECK: store i32 22 > z = 22; > } > @@ -94,16 +94,16 @@ > // CHECK: define void @_Z12for_destruct > // CHECK: call void @_ZN1YC1Ev > for(Y y = Y(); X x = X(); ++z) > - // CHECK: {{for.cond:|:1}} > + // CHECK: {{for.cond:|:2}} > // CHECK: call void @_ZN1XC1Ev > - // CHECK: {{for.body:|:3}} > + // CHECK: {{for.body:|:4}} > // CHECK: store i32 23 > z = 23; > - // CHECK: {{for.inc:|:4}} > - // CHECK: br label %{{for.cond.cleanup|7}} > - // CHECK: {{for.cond.cleanup:|:7}} > + // CHECK: {{for.inc:|:5}} > + // CHECK: br label %{{for.cond.cleanup|8}} > + // CHECK: {{for.cond.cleanup:|:8}} > // CHECK: call void @_ZN1XD1Ev > - // CHECK: {{for.end:|:9}} > + // CHECK: {{for.end:|:10}} > // CHECK: call void @_ZN1YD1Ev > // CHECK: store i32 24 > z = 24; > > Modified: cfe/trunk/test/CodeGenCXX/virt.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/virt.cpp?rev=95658&r1=95657&r2=95658&view=diff > > === > === > === > ===================================================================== > --- cfe/trunk/test/CodeGenCXX/virt.cpp (original) > +++ cfe/trunk/test/CodeGenCXX/virt.cpp Tue Feb 9 02:22:03 2010 > @@ -718,10 +718,10 @@ > // CHECK-LPLL64} > > // CHECK-LPLL64:define weak %class.test8_D* > @_ZTch0_v16_n32_N8test16_D4foo1Ev(%{{class.test8_D|.*}}*) > -// CHECK-LPLL64: %{{retval|2}} = alloca %class.test8_D* > -// CHECK-LPLL64: %.addr = alloca %class.test8_D* > -// CHECK-LPLL64: store %class.test8_D* %0, %class.test8_D** %.addr > -// CHECK-LPLL64: %{{this|3}} = load %class.test8_D** %.addr > +// CHECK-LPLL64: %{{retval|1}} = alloca %class.test8_D* > +// CHECK-LPLL64: %{{.addr|2}} = alloca %class.test8_D* > +// CHECK-LPLL64: store %class.test8_D* %0, %class.test8_D** % > {{.addr|2}} > +// CHECK-LPLL64: %{{this|3}} = load %class.test8_D** %{{.addr|2}} > // CHECK-LPLL64: %{{call|4}} = call %class.test8_D* > @_ZN8test16_D4foo1Ev(%class.test8_D* %{{this|3}}) > // CHECK-LPLL64: %{{1|5}} = icmp ne %class.test8_D* %{{call|4}}, null > // CHECK-LPLL64: br i1 %{{1|5}}, label %{{2|6}}, label %{{12|17}} > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
