Re: [cfe-commits] r95820 - in /cfe/trunk: include/clang/AST/Attr.h lib/AST/AttrImpl.cpp lib/Sema/TargetAttributesSema.cpp test/Sema/x86-attr-force-align-arg-pointer.c

[Charles Davis]

Anton Korobeynikov wrote:
> Hi, Charles
> 
>> +  ValueDecl* VD = dyn_cast<ValueDecl>(D);
> You either need a check of NULL here, or use cast<>
D'oh! Fixed now.
> 
>> +  if(VD->getType()->isFunctionPointerType())
> Space after "if"
Fixed that, too.
> 
>> +  if(!isa<FunctionDecl>(D)) {
> Same here
And that.
> 

Thanks for that! (And John McCall said it looked fine to him...)

Chip
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits