Hello, Charles

> This is a very simple patch, but I want feedback on it before I put it in.
You're emitting a target-specific attribute inside generic codegen code.

There is a special helper class, TargetCodeGenInfo, which is expected
to emit "simple" attribute-like goodness (function attributes, calling
conventions, etc).

Look into MSP430TargetCodeGenInfo inside CodeGen/TargetInfo.cpp

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to