2 jun 2010 kl. 08.50 skrev Daniel Dunbar: > Hi Anders, > > On Tue, Jun 1, 2010 at 10:07 PM, Anders Carlsson <[email protected]> wrote: >> Author: andersca >> Date: Wed Jun 2 00:07:26 2010 >> New Revision: 105312 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=105312&view=rev >> Log: >> Correctly mangle unsigned integer literals where the high bit is set. >> >> Modified: >> cfe/trunk/lib/CodeGen/Mangle.cpp >> cfe/trunk/test/CodeGenCXX/mangle.cpp >> >> Modified: cfe/trunk/lib/CodeGen/Mangle.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/Mangle.cpp?rev=105312&r1=105311&r2=105312&view=diff >> ============================================================================== >> --- cfe/trunk/lib/CodeGen/Mangle.cpp (original) >> +++ cfe/trunk/lib/CodeGen/Mangle.cpp Wed Jun 2 00:07:26 2010 >> @@ -1391,9 +1391,11 @@ >> // Boolean values are encoded as 0/1. >> Out << (Value.getBoolValue() ? '1' : '0'); >> } else { >> - if (Value.isNegative()) >> + if (Value.isSigned() && Value.isNegative()) { >> Out << 'n'; >> - Value.abs().print(Out, false); >> + Value.abs().print(Out, true); >> + } else >> + Value.print(Out, Value.isSigned()); > > Should this be > Value.print(Out, false); > ?
Could be, I don't think it'd make a difference though. - Anders _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
