Re: [cfe-commits] r106584 - in /cfe/trunk: include/clang/AST/CanonicalType.h include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaOverload.cpp

[Douglas Gregor]

On Jun 22, 2010, at 5:06 PM, Eli Friedman wrote:

> On Tue, Jun 22, 2010 at 3:12 PM, Douglas Gregor <dgre...@apple.com> wrote:
>> Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
>> URL: 
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=106584&r1=106583&r2=106584&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Tue Jun 22 17:12:46 2010
>> @@ -1410,7 +1410,7 @@
>> 
>>   FieldDecl *FirstField = *Field;
>>   QualType FirstType = FirstField->getType();
>> -  if (FirstType->isFloatingType() || FirstType->isVectorType()) {
>> +  if (FirstType->hasFloatingRepresentation()) {
>>     S.Diag(FirstField->getLocation(),
>>            diag::warn_transparent_union_attribute_floating);
>>     return;
> 
> Umm, I think this is supposed to warn on integer vectors too.

Ah, you are correct, thanks! Fixed in r107296.

        - Doug
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits