Looks great!  Much simpler.

One comment:

  if (N)
   Dst.add(N);

is the same as:

  Dst.add(N);

since the ExplodedNodeSet::Add() does the null check as well.

On Jul 15, 2010, at 7:56 PM, Zhongxing Xu wrote:

> Hi Ted,
> 
> I think using AnalysisContext in CallEnter is a good idea. New patch
> implemented this. It's simpler than the original one.
> 
> Now we stop at GRCallEnterNodeBuilder::GenerateNode(). Here if the
> CallEnter has a different translation unit, a new engine is to be
> created.
> <b.patch>

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to