On Aug 6, 2010, at 2:04 PM, Douglas Gregor wrote: >> >> Did you do any performance checking of this? HeaderSearch::LookupFile is >> incredibly performance sensitive for certain things (e.g. building cocoa.h >> pch file) and this patch probably just slowed it down by 3x. > > > Hrm, I did not do any performance testing. I'll run some numbers in the > morning and revert the patch if it causes an issue. Thanks for keeping an eye > out; you know I aim to make Clang slow.
I think it's best to just revert this patch. Using sys::Path isn't the right solution here from a design perspective anyway. If you revert the patch I'll try to look at it again in the next couple weeks. -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
