On Sep 11, 2010, at 6:07 PM, Daniel Dunbar wrote:
> Hi Doug,
>
> On Sep 10, 2010, at 16:05, Douglas Gregor <[email protected]> wrote:
>
>> Author: dgregor
>> Date: Fri Sep 10 18:05:54 2010
>> New Revision: 113656
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=113656&view=rev
>> Log:
>> Fix my silly sorting predicate. I hate integer-to-bool conversions
>>
>> Modified:
>> cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp
>>
>> Modified: cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp?rev=113656&r1=113655&r2=113656&view=diff
>> ==============================================================================
>> --- cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp (original)
>> +++ cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp Fri Sep 10 18:05:54
>> 2010
>> @@ -809,7 +809,7 @@
>> return false;
>>
>> result = llvm::StringRef(XText).compare(YText);
>> - return result;
>> + return result < 0;
>
> Isn't this simpler as
> llvm::StringRef(XText) < YText;
It's a parallel-structure thing, with the compare_lower call above.
- Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
