W dniu 14 września 2010 23:25 użytkownik Ted Kremenek <[email protected]>napisał:
> > On Sep 14, 2010, at 10:41 AM, Marcin Świderski wrote: > > > I'm used to using named parameters object as temporary created in > function's parameters list, just like I did in AnalysisContext.cpp . Such > approach is clearer IMO, because it shows exactly what I want to achieve: > pass parameters to function, and not create an object named B and pass it to > function. > > > > But that's just my opinion and I can remove those setters if it will > better fit the whole project. > > I think it's an elegant design, but in this case it adds 17 lines of code > for the method definitions just to simplify two callsites where the CFG is > constructed. In that regards it seems like overkill. If this was an API > that would be used in many places (and the object copies could be elided), > I'd be right there with you. I'd rather just keep the BuildOptions object > simple. Fixed
cfg-build-options.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
