On Sep 15, 2010, at 10:06 AM, Sebastian Redl wrote: > On Sep 15, 2010, at 3:14 AM, John McCall wrote: >> Implement generalized copy elision > > Does this mean we can finally finish our rvalue ref implementation?
Can you explain how this was blocking that? >> Modified: cfe/trunk/lib/AST/Expr.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Expr.cpp?rev=113962&r1=113961&r2=113962&view=diff >> ============================================================================== >> --- cfe/trunk/lib/AST/Expr.cpp (original) >> +++ cfe/trunk/lib/AST/Expr.cpp Wed Sep 15 05:14:12 2010 >> @@ -1648,46 +1648,31 @@ >> + // pr-values of class type are always temporaries. >> + if (!E->Classify(C).isPRValue()) return false; > > Isn't this comment the wrong way around? Sure, both directions are valid, but > given the pruning nature of the if, I would expect the comment to say that > temporaries are always prvalues. (Thus, if the expression isn't, it can't be > a temporary.) Good point. John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
