On Oct 14, 2010, at 2:41 PM, jahanian wrote: > > On Oct 14, 2010, at 2:35 PM, Argyrios Kyrtzidis wrote: > >> Author: akirtzidis >> Date: Thu Oct 14 16:35:29 2010 >> New Revision: 116521 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=116521&view=rev >> Log: >> Fix compiler error that clang didn't report (probably same problem as >> rdar://8552377). > > Do you mean that this is the workaround for above bug? If so, then you need > to add a FIXME > to undo the change once the bug is fixed.
No, I mean there was a legitimate compiler error in my patch that clang didn't report (but buildbots using gcc reported it). -Argiris > > - Fariborz > >> >> It's more stress-free without access checking though.. >> >> Modified: >> cfe/trunk/include/clang/AST/Decl.h >> >> Modified: cfe/trunk/include/clang/AST/Decl.h >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Decl.h?rev=116521&r1=116520&r2=116521&view=diff >> ============================================================================== >> --- cfe/trunk/include/clang/AST/Decl.h (original) >> +++ cfe/trunk/include/clang/AST/Decl.h Thu Oct 14 16:35:29 2010 >> @@ -2220,7 +2220,7 @@ >> /// methods/nested types we allow deserialization of just the fields >> /// when needed. >> mutable bool LoadedFieldsFromExternalStorage : 1; >> - friend void DeclContext::LoadLexicalDeclsFromExternalStorage() const; >> + friend class DeclContext; >> >> protected: >> RecordDecl(Kind DK, TagKind TK, DeclContext *DC, >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
