Andy, thank you...Takumi
2010/10/21 Andy Trick <[email protected]>: > Takumi, > > I initially reverted both changes that were blamed in the build log in case > there was some dependency. But you're right, the first change is a safe fix. > I checked it back in now that the windows builds are clean. > > -Andy > > On Oct 20, 2010, at 5:32 PM, NAKAMURA Takumi wrote: > >> Andrew, >> >> Thank you to work on. >> I did not know the buildbot does not have find.exe. >> (is it not included in gnuwin32?) >> >> One opinion. >> >>> -// CHECK: {{[D]ereference of null pointer}} >>> +// CHECK: Dereference of null pointer >> >> It's a bug. Why did you revert it? >> (It is because I split my patch into two) >> >> ...Takumi >> >> >> 2010/10/21 Andrew Trick <[email protected]>: >>> Author: atrick >>> Date: Wed Oct 20 18:52:37 2010 >>> New Revision: 116976 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=116976&view=rev >>> Log: >>> revert r116782 & r116793 to fix msvc9 buildbots >>> >>> Modified: >>> cfe/trunk/test/Coverage/html-diagnostics.c >>> >>> Modified: cfe/trunk/test/Coverage/html-diagnostics.c >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Coverage/html-diagnostics.c?rev=116976&r1=116975&r2=116976&view=diff >>> ============================================================================== >>> --- cfe/trunk/test/Coverage/html-diagnostics.c (original) >>> +++ cfe/trunk/test/Coverage/html-diagnostics.c Wed Oct 20 18:52:37 2010 >>> @@ -1,12 +1,9 @@ >>> // RUN: rm -rf %t >>> // RUN: %clang_cc1 -analyze -analyzer-output=html -analyzer-check-objc-mem >>> -o %t %s >>> -// RUN: find %t -type f -name '*.html' -exec cat '{}' ';' | FileCheck %s >>> +// RUN: cat %t/*.html | FileCheck %s >>> >>> // CHECK: <h3>Annotated Source Code</h3> >>> - >>> -// Without tweaking expr, the expr would hit to the line below >>> -// emitted to the output as comment. >>> -// CHECK: {{[D]ereference of null pointer}} >>> +// CHECK: Dereference of null pointer >>> >>> void f0(int x) { >>> int *p = &x; >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
