On Nov 5, 2010, at 10:51 PM, Chris Lattner wrote: > > On Nov 5, 2010, at 3:10 PM, Argyrios Kyrtzidis wrote: > >> Author: akirtzidis >> Date: Fri Nov 5 17:10:14 2010 >> New Revision: 118302 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=118302&view=rev >> Log: >> Initialize the array with the "C++ way". >> >> Modified: >> cfe/trunk/include/clang/Basic/Diagnostic.h >> >> Modified: cfe/trunk/include/clang/Basic/Diagnostic.h >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Diagnostic.h?rev=118302&r1=118301&r2=118302&view=diff >> ============================================================================== >> --- cfe/trunk/include/clang/Basic/Diagnostic.h (original) >> +++ cfe/trunk/include/clang/Basic/Diagnostic.h Fri Nov 5 17:10:14 2010 >> @@ -215,9 +215,7 @@ >> unsigned char Values[diag::DIAG_UPPER_LIMIT/2]; >> >> public: >> - DiagMappings() { >> - memset(Values, 0, diag::DIAG_UPPER_LIMIT/2); >> - } >> + DiagMappings() : Values() { } > > Ok, but please add a comment. This is "really subtle" and I for one wouldn't > think twice about zapping that.
Done. > > -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
