On Nov 11, 2010, at 2:36 PM, Amer Agovic wrote:

> Here is it again.
> Take a look and if acceptable please integrate. Please let me know.
> 
> Why did I bother:
>  1.) I have MinGW under c:\projects\bin which is not default
>  2.) I use TDM Dwarf compilation which changes lib paths to append -dw2 at 
> the end
> 
> This addition basically adds code to parse env variables like PATH and 
> extract the root.
> It also queries GCC for certain things. Similar code can be added for other 
> supported compilers.

Couple of quick comments:

a) Please use C++ comments
b) You probably want to use StringRef instead of std::string.

I'm sure Daniel is going to have more comments, and probably me too when I get 
a chance to look at it a bit more.

-eric
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to