Okay, works for me.  The patch looks good as is.  I just wanted to raise the 
point that BasicStore after all is "basic", and I'm not certain if it makes 
much more sense to extend it to model more of C++.

On Nov 15, 2010, at 3:55 PM, Marcin Świderski wrote:

> I'm currently using it for tracking object identity and more precicly 
> checking if object is the 'this' object.
> 
> W dniu 16 listopada 2010 00:49 użytkownik Ted Kremenek <[email protected]> 
> napisał:
> 
> I don't think BasicStore will ever be useful for analyzing C++ code.  I'm 
> fine with restricting its use to C and Objective-C code at this point.  
> There's just so much it won't model for C++ to be remotely useful, and the 
> maintenance isn't worth it.
> 
> Any objections?
> 
> On Nov 15, 2010, at 3:47 PM, Marcin Świderski wrote:
> 
>> Patch adds support for CXXThisRegion in BasicStore. CXXThisRegion is treated 
>> like VarRegion and ObjCIVarRegion. Also there's small change in 
>> BindDeclInternal to treat reference decls like pointer decls.
>> 
>> Please aprove for commit.
>> 
>> - Marcin
>> <gr-eng-cxx-this-reg-in-basic-store.patch>
> 
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to