MSVC still doesn't compile that. Attributes must be at the beginning on msvc

Use:
  LLVM_ATTRIBUTE_NOINLINE bool VisitDataRecursive(Stmt *S);


On Mon, Nov 15, 2010 at 6:10 PM, Ted Kremenek <[email protected]> wrote:
> Absolutely.  I'll fix.
>
> On Nov 15, 2010, at 2:45 PM, Frits van Bommel wrote:
>
>> On Mon, Nov 15, 2010 at 11:23 PM, Ted Kremenek <[email protected]> wrote:
>>> -  bool VisitDataRecursive(Stmt *S);
>>> +  bool VisitDataRecursive(Stmt *S) __attribute__((noinline));
>>
>> Shouldn't that be
>>  #include "llvm/Support/Compiler.h"
>>  // ...
>>  bool VisitDataRecursive(Stmt *S) LLVM_ATTRIBUTE_NOINLINE;
>> ?
>>
>> That way you also support MSVC, and shouldn't error out on compilers
>> that don't support __attribute__((noinline)).
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to