On Jan 31, 2011, at 3:07 PM, Alex Miller wrote:

> Patch looks good. Could you provide a test case that we can integrate into 
> Clang's test suite, e.g., that extends test/SemaCXX/new-delete.cpp?
> 
> Done. 
>  
> > If someone could point out how to turn the QualType instance representing 
> > 'Foo *' into just 'Foo', I'd appreciate it.
> 
> 
> Isn't PointeeElem the type you want to print?
> 
> In any case, if you want to dig out the type that a QualType T points to, use 
> something like
> 
>        if (const PointerType *PointerT = T->getAs<PointerType>()) {
>                // PointerT->getPointeeType() is the type that T points to
>        }
> 
> Thanks for pointing out that PointeeElem already held the right type. Fixed.
>  
> 
> Could you re-submit the patch with those tweaks? Thanks for working on this!
> 
>        - Doug
> 
> Attached and no problem! :)

Committed as r124663 with some minor tweaks (i.e., this found some latent bugs 
in the test suite). Thanks!

        - Doug


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to