On Mar 26, 2011, at 6:50 PM, Chandler Carruth wrote: > Author: chandlerc > Date: Sat Mar 26 20:50:55 2011 > New Revision: 128371 > > URL: http://llvm.org/viewvc/llvm-project?rev=128371&view=rev > Log: > Add an option to suppress include stack printing on note diagnostics. > These stacks are often less important than those on primary diagnostics. > > As the number of notes grows, this becomes increasingly important. The > include stack printing is clever and doesn't print stacks for adjacent > diagnostics from the same file, but when a note is in between a sequence > of errors in a header file, and the notes all refer to some other file, > we end up getting a worst-case ping-pong of include stacks that take up > a great deal of vertical space. > > Still, for now, the default behavior isn't changed. We can evaluate user > feedback with the flag. > > Patch by Richard Trieu, a couple of style tweaks from me.
When is printing the include stack for a note ever a good idea? I think we should just remove it unconditionally. -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
