Just a few stylistic comments. Generally looks fine to me. I'll be glad to see the notes added back at some point. =D
http://codereview.appspot.com/4439065/diff/1/include/clang/Sema/Sema.h File include/clang/Sema/Sema.h (right): http://codereview.appspot.com/4439065/diff/1/include/clang/Sema/Sema.h#newcode1940 include/clang/Sema/Sema.h:1940: bool CanCall(const Expr* E, QualType& ZeroArgCallReturnTy, I think a bit more context in the name would help when this is stuffed into the Sema interface of dhoom... IsExprCallable? IsExprCallableFunction? http://codereview.appspot.com/4439065/diff/1/lib/Sema/Sema.cpp File lib/Sema/Sema.cpp (right): http://codereview.appspot.com/4439065/diff/1/lib/Sema/Sema.cpp#newcode757 lib/Sema/Sema.cpp:757: /// Use this when trying to recover from an error that could have been due to "... that could have been due to the programmer writing ..." to "... where the programmer may have written ..." http://codereview.appspot.com/4439065/diff/1/lib/Sema/Sema.cpp#newcode767 lib/Sema/Sema.cpp:767: bool Sema::CanCall(const Expr* E, QualType& ZeroArgCallReturnTy, Can E be NULL? If not, maybe use a const & here? http://codereview.appspot.com/4439065/diff/1/lib/Sema/SemaExpr.cpp File lib/Sema/SemaExpr.cpp (right): http://codereview.appspot.com/4439065/diff/1/lib/Sema/SemaExpr.cpp#newcode4340 lib/Sema/SemaExpr.cpp:4340: UnresolvedSet<4> AllOverloads; Maybe an inline size of 1 instead of 4? That seems to be the case you're optimizing for anyways... but then again, we've already hit an error. http://codereview.appspot.com/4439065/diff/1/lib/Sema/SemaExpr.cpp#newcode4342 lib/Sema/SemaExpr.cpp:4342: if (ZeroArgCallTy.isNull()) { No need for an explicit isNull(), conversion to bool works here. http://codereview.appspot.com/4439065/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
