On Apr 28, 2011, at 11:26 AM, Chris Lattner wrote: > > On Apr 28, 2011, at 11:16 AM, Stuart Hastings wrote: > >> Author: stuart >> Date: Thu Apr 28 13:16:06 2011 >> New Revision: 130417 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=130417&view=rev >> Log: >> Replace SmallVector with an array, as suggested by Frits van Bommel. >> rdar://problem/7662569 > > Thanks Stuart, > >> + const llvm::Type* LLVMField[1] = { llvm::ArrayType::get(ElemTy, SizeRegs) >> }; > > You don't actually need an array here (you can pass in a scalar instead).
O.K., but I had to pass two NULLs (looks odd) so the call could be dis-ambiguated. The resulting structure won't be packed, but I don't think that's critical here. Patch in 130423. (FWIW, the ambiguous decls in question are near lines 248 and 261 of DerivedTypes.h.) >> + const llvm::Type* STy = llvm::StructType::get(getVMContext(), LLVMField, >> + true); >> + return ABIArgInfo::getDirect(STy); > > Please use "Type *STy" instead of "Type* STy". D'oh! stuart _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
