Re: [cfe-commits] r130670 - in /cfe/trunk: include/clang/AST/Expr.h include/clang/AST/Stmt.h lib/AST/ASTImporter.cpp lib/AST/Expr.cpp lib/AST/StmtDumper.cpp lib/Sema/SemaOverload.cpp lib/Serialization/ASTReaderStmt.cpp lib/Serialization/ASTWriterStmt.cpp

[John McCall]

On May 1, 2011, at 4:48 PM, Chandler Carruth wrote:
> @@ -327,29 +333,38 @@
>                                  const DeclarationNameInfo &NameInfo,
>                                  QualType T,
>                                  ExprValueKind VK,
> +                                 NamedDecl *FoundD,
>                                  const TemplateArgumentListInfo 
> *TemplateArgs) {
> +  // Filter out cases where the found Decl is the same as the value 
> refenenced.
> +  if (D == FoundD)
> +    FoundD = 0;
> +

I would be happier if we also filtered out cases where the found
Decl can be trivially reconstructed from the value referenced, as with
a function template specialization.

John.
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits