Hi Bruno, These look fine to me. However, is it necessary to use def : Pat patterns? Can't you fold the patterns into the instruction defs?
Evan On Apr 29, 2011, at 5:26 PM, Bruno Cardoso Lopes wrote: > Hi all, > > I know in some cases we prefer avoiding the usage of intrinsics as > much as possible and I'm not aware what it's the policy regarding the > addition of new ARM builtins and intrinsics. However, this patch > implements builtins and intrinsics for some coprocessor instructions, > they have a clean interface and directly match the real instructions. > > Is it OK to commit? > > -- > Bruno Cardoso Lopes > http://www.brunocardoso.cc > <clang-arm-intrinsics.patch><llvm-arm-intrinsics.patch>_______________________________________________ > llvm-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
