Hi Rui, I think this is a great start for adding additional functionality to that checker. Please include test cases for this additional functionality. You can see how tests for the analyzer are written by looking at the test/Analysis directory. At the very least, there should be a handful of tests showing that the analyzer warning in expected cases, and not warning for correct cases.
Cheers, Ted On May 6, 2011, at 1:03 PM, Rui Paulo wrote: > Hi, > > The following attached patch adds two locking checks to the static analyzer: > 1) finds double locking problems > 2) finds double unlocking problems > > I also added a few lines of code so that this checker can be used with > pthread rw locks and also with xnu locks. > > Regards, > -- > Rui Paulo > <LockChecker_FirstChecks.diff>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
