On Jun 2, 2011, at 2:08 AM, Hans Wennborg wrote:
> On Wed, Jun 1, 2011 at 9:20 PM, Douglas Gregor <[email protected]> wrote:
>> This is looking really good. The only issue I see is when comparing source
>> locations with <, e.g.,
>>
>> + if (!Loc.isValid() || ConstQualLoc < Loc)
>> + Loc = ConstQualLoc;
>>
>> The < operator on SourceLocation doesn't necessarily mean "before in the
>> translation"; it's a somewhat arbitrary total ordering useful mainly for use
>> in std::map or std::set.
>>
>> Instead, I suggest using SourceManager::isBeforeInTranslationUnit().
>
> Thanks Doug! New patch attached.
Patch looks good! If you have commit access, please go ahead and commit. If
not, please follow the directions here
http://llvm.org/docs/DeveloperPolicy.html#commitaccess
so you can commit patches after approval. Thanks!
- Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
