On Jun 3, 2011, at 10:06 AM, Anders Carlsson wrote: > > On Jun 2, 2011, at 7:16 PM, Douglas Gregor wrote: > >> >> On Jun 2, 2011, at 7:04 PM, Marshall Clow wrote: >> >>> Author: marshall >>> Date: Thu Jun 2 21:04:41 2011 >>> New Revision: 132524 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=132524&view=rev >>> Log: >>> Added __cxa_bad_cast and __cxa_bad_typeid and placeholder NORETURN macro >> >> Marshall, did someone pre-approve this commit? >> >> LIBCXXABI_NORETURN should be trivial to implement correctly, given that we >> have an attribute for it. Why commit a placeholder when it's easier to do >> the right thing? >> >> Also, any commit needs accompanying tests. >> >> Please revert this. >> >> - Doug > > Also, you're including <typeinfo> which doesn't exist yet; it should also be > provided by libcxxabi.
Yes, until this library is actually functional, there's going to be problems like this. I'd prefer to fix this by creating <typeinfo> rather than putting workarounds into libcxxabi. The workaround for testing is to simply compile against an existing C++ lib like libc++. Howard _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
