On Fri, Jun 17, 2011 at 7:38 PM, Richard Trieu <[email protected]> wrote:
> -Wnull-arithmetic was catching some false positives. Switch the checking > code so that it will warn on specific types instead of not warning on > specific types. Now, comparisons between non-boolean arithmetic types and > NULL will give this warning. New types to warn on can be added later if > needed. I'm a bit worried that the set of things we *don't* want to warn about is more clearly defined than the set of things we *do*. I'm inclined to implement the warning accordingly. I think we just need something more forgiving than 'isPointerType'. I'm looking at committing a variation of this patch (your test cases are excellent) that instead enhances the AST to have an interface specifically designed to represent this class of types. We can implement that much more efficiently as a bonus, and this is a hot-path in Clang.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
