On Jun 21, 2011, at 4:22 PM, Richard Osborne wrote:
>
> On 21 Jun 2011, at 16:21, Douglas Gregor wrote:
>
>>
>> On Jun 18, 2011, at 12:00 PM, Richard Osborne wrote:
>>
>>> This patch adds support for printing diagnostic pragmas to the preprocessed
>>> output. Previously they would be discarded
>>> (http://llvm.org/bugs/show_bug.cgi?id=5952).
>>>
>>> Please let me know if this patch looks OK.
>>
>> Your patch looks very good.
>>
>>> Note diagnostic pragmas in the clang and GCC pragma namespaces will both be
>>> printed as "#pragma GCC diagnostic ...". I assumed this wouldn't matter as
>>> they should have the same behaviour.
>>
>>
>> I'd much prefer that we get the output perfect, by tracking which pragma
>> namespace was specified and emitting the output the same way. Otherwise,
>> we'll just end up getting a bug report 6 months down the line asking for
>> more precise output :)
>>
>> - Doug
>
> Thanks for your comments. An updated patch is attached which keeps tracks the
> of pragma namespace so the same one can be used in the output.
Looks great, thanks! I've committed this as r133633.
- Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
