Ping. On Tue, Jun 21, 2011 at 4:50 PM, Richard Trieu <[email protected]> wrote:
> Instead of passing around an enum, a vector of QualTypes is passed into the > function where the aka strings are generated. This should be the latest > that the comparisons can be held off. > > > On Thu, May 26, 2011 at 3:06 AM, Chandler Carruth <[email protected]>wrote: > >> On Mon, Apr 25, 2011 at 8:38 PM, Richard Trieu <[email protected]> wrote: >> >>> Ping. Any comments on this patch? >> >> >> I like the general direction of this patch, but I have one nit, and one >> more serious comment. >> >> nit: You should switch back to the enum for the ArgumentKind in your >> interface rather than exposing the raw 'char' storage type. This may be made >> irrelevant by the major comment though.... >> >> My big issue is similar to Sebastian's. This slows down the *building* of >> diagnostics. It would be much better to do all of this logic in the >> Diagnostic class. >> >> To give a concrete reason, SFINAE: we sometimes build many many >> diagnostics merely to detect the presence of them, discard a particular type >> with those diagnostics, and then begin semantically analyzing something >> else. We don't want to pay for this type of formatting logic in that case. >> We only want to pay for it when we are *emitting* the diagnostic. >> >> Another reason; after we've hit the max diagnostic emitted limit, it would >> be good to cut any and every corner we can to speed things up. >> >> Finally, I think it will be more semantically clear. No need to funnel an >> enum through so many layers, etc. >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
