On 11-07-13 01:42 PM, Sean Hunt wrote: > On 11-07-13 02:03 AM, Toralf Niebuhr wrote: >> Hi, >> >> these are just two small patches fixing the libc++ build for Mac OS X. >> >> The first patch replaces an "#ifndef LIBCPP_STABLE_APPLE_ABI" with "#ifdef >> LIBCPP_STABLE_APPLE_ABI". >> This is probably a copy and paste error as it's usually used with "#ifndef" > > Yes, thanks. I'll make sure to apply this separately. > >> The second patch replaces "__funcs()" with "func()". The underscore calls >> are encapsulated with the calls without underscores in the "locale" header. > > The __func() calls are necessary, as the corresponding non-underscore > functions are only extensions and not present on some platforms. The > functions in the headers have underscores because the names are nor > reserved and thus to work on every platform they must use reserved > identifiers.
And now it occurs to me what the real issue is; I forgot to wrap those function calls in conditional inclusion on the _LIBCPP_STABLE_APPLE_ABI macro. Sean _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
