On Jul 17, 2011, at 2:41 PM, [email protected] wrote: > Reviewers: cfe-commits_cs.uiuc.edu, > > Message: > Initial diff at > http://codereview.appspot.com/download/issue4749047_1.diff. > > I haven't tested the makefile yet. > > Description: > Define DiagnosticBuilder<<APValue so it's easy to include APValues in > diagnostics. This is likely to get more important as generalized > constant expressions get implemented.
Please send patches to the list, not links to an external review site. Why is WriteShortAPValueToStream templated? Please convert it to always take a raw_ostream and handle the builder case outside the recursive call. -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
