On Jul 20, 2011, at 11:45 PM, David Blaikie wrote:
>>> + PreprocessedEntities.insert(PreprocessedEntities.end(),
>>> + PPRec->begin(true), PPRec->end(true));
>>
>> Hi, I added a operator< to PreprocessingRecord::iterator otherwise
>> MSVC will refuse to compile the insert line in DEBUG mode.
>> see r135670
>
> That seemed a bit curious, so I went to check why: In case it wasn't
> obvious to anyone else too: it's because PreprocessingRecord::iterator
> declares itself to be random access (PreprocessingRecord.h:329) &
> looks like it is pretty much entirely random access (supports op+/-,
> etc) but just missing some of the required operations.
>
> At a glance it looks like it's still missing op-(iterator,
> difference_type) and op-(difference_type, iterator). Easy enough to
> address should they ever be needed though, I suppose.
Thanks David and Francois. I've added the missing operations.
- Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
