On Jul 30, 2011, at 8:48 AM, Howard Hinnant wrote: > Please revert immediately. > > Please do not check in code that is unreviewed, and that you do not > understand.
Sean, please follow the developer policy and get non-obvious patches reviewed before commit. Howard, if Sean does not revert the patches, feel free to do so yourself. -Chris > > Howard > > On Jul 29, 2011, at 8:18 PM, Sean Hunt wrote: > >> Author: coppro >> Date: Fri Jul 29 19:18:12 2011 >> New Revision: 136546 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=136546&view=rev >> Log: >> Destruct elements of hash tables when removing individual entries from >> the hash_table. I think this is the correct solution to PR10507, but I'm >> not sure since this is a little bit cargo-culted. Howard, please review. >> >> Modified: >> libcxx/trunk/include/__hash_table >> >> Modified: libcxx/trunk/include/__hash_table >> URL: >> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__hash_table?rev=136546&r1=136545&r2=136546&view=diff >> ============================================================================== >> --- libcxx/trunk/include/__hash_table (original) >> +++ libcxx/trunk/include/__hash_table Fri Jul 29 19:18:12 2011 >> @@ -1726,6 +1726,7 @@ >> typename __hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_holder >> __hash_table<_Tp, _Hash, _Equal, _Alloc>::remove(const_iterator __p) >> _NOEXCEPT >> { >> + __node_traits::destroy(__node_alloc(), __p.operator->()); >> // current node >> __node_pointer __cn = const_cast<__node_pointer>(__p.__node_); >> size_type __bc = bucket_count(); >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
