On Sep 7, 2011, at 10:38 AM, Argyrios Kyrtzidis wrote:
> On Sep 6, 2011, at 10:07 PM, Douglas Gregor wrote:
>
>>
>> On Sep 6, 2011, at 8:43 PM, Argyrios Kyrtzidis wrote:
>>
>>> Author: akirtzidis
>>> Date: Tue Sep 6 22:43:39 2011
>>> New Revision: 139222
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=139222&view=rev
>>> Log:
>>> operator->() in PreprocessingRecord::iterator is useless since we
>>> are returning a pointer to pointer.
>>
>> It's there to meet the requirements of the InputIterator concept.
>
> It seemed less convenient to implement after some changes but in retrospect
> this is not the case, I'll put it back.
>
> But how about changing PreprocessingRecord::iterator::value_type from
> PreprocessedEntity * to PreprocessedEntity ? That iterator is not supposed to
> ever return a null PreprocessedEntity * anyway.
If a PreprocessedEntity cannot be deserialized, we probably need some way to
indicate failure… although I guess we could put a fake PreprocessedEntity in
its place, and it would be nicer to have the iterator return PreprocessEntity
references.
- Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
