Looks great!

        - Doug

On Sep 7, 2011, at 3:19 PM, Delesley Hutchins wrote:

> Updated patch:
> 
>  http://codereview.appspot.com/4993045/
> 
>> Well… okay, if we have to check in the parser whether we have a function, 
>> please use
>> Decl::isFunctionOrFunctionTemplate() and handle the function-template case.
> 
> An excellent point!  Done.
> 
>> How about naming these EnterDelayedFunctionContext and 
>> ExitDelayedFunctionContext?
> 
> I renamed these ActOnReenterFunctionContext, to match
> ActOnReenterTemplateScope,
> which does something very similar.
> 
>  -DeLesley
> 
> -- 
> DeLesley Hutchins | Software Engineer | [email protected] | 505-206-0315
> <function_parameter_parsing4.patch>


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to