On Wed, Sep 14, 2011 at 1:24 PM, Caitlin Sadowski <[email protected]>wrote:
> Chandler, > > If you could review the first two patches, I would like to submit them > today, if possible. > Sorry for delays. First three are reviewed. I think only significant changes needed in the third. Will review the fourth when you have a cleaned up patch... i tried to review it as-is, but couldn't get through the weird whitespace and other random formatting changes. > > > Here is a first patch that refactors how errors are reported for > > situations where there is inconisitency between locks: > > http://codereview.appspot.com/4964080 > > > > Building off of that, here is a patch that deals with locks required > > attributes at function boundaries: > > http://codereview.appspot.com/4995046 > > Note: the fourth patch has a bunch of erroneous whitespace changes > (IDE fail). I will send out a replacement shortly. > > Cheers, > > Caitlin >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
