On Sep 16, 2011, at 6:11 PM, Eric Christopher wrote: > > On Sep 16, 2011, at 5:31 PM, Bob Wilson wrote: > >> This is basically just a revert of Sean Hunt's change 135455, but you did >> not remove the addition of __WCHAR_UNSIGNED__. That macro is now only used >> in a test. If we're not keeping the rest of that change, we should drop the >> unused macro as well. >> > > Yeah. We should use it to conditionalize.
I don't understand what you mean about using it to conditionalize. If you think it's important to keep the __WCHAR_UNSIGNED__ predefined macro, can you elaborate on the reason? > >> Sean, can you clarify what problem you were trying to solve with that >> change? The commit message was: >> >> "Implement a __WCHAR_UNSIGNED__ macro and use it to include WCHAR_MIN and >> WCHAR_MAX in limits.h, thus solving the problem where the system header >> thinks it knows better." > > > Sean? I'm pretty sure this can't be correct. I haven't seen a response from Sean, and I'd rather not leave his patch in the current partially-reverted state. Eric, unless you want to make a case for keeping __WCHAR_UNSIGNED__, can you remove the rest of 135455? We can reconsider later if Sean shows up to explain the rationale for his change. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
