I'm not sure this is a good idea. I understand the concern about having -W flags for all warnings, but we certainly don't anyone to start using -Wno-unsupported-debug-with-integrated-as. As soon as the integrated assembler can support debug info, we're going to rip out this warning, and we don't want to be stuck keeping the -W flags around for backward compatibility. Is there some existing warning group that we could use for this?
On Oct 4, 2011, at 7:54 AM, Ted Kremenek wrote: > Hi Chad, > > I went ahead and reverted r141060, and added the warning under a -Wflag > (r141078). I know it seems weird to put driver warnings under -W flags, but > it is consistent with out goal of putting every warning under a -Wflag. This > allows users to suppress any warning (group) they choose, or promote any > warning group to an error. > > Cheers, > Ted > > On Oct 3, 2011, at 9:46 PM, Chad Rosier wrote: > >> Should be fixed with r141060. Sorry for the breakage. >> >> Chad >> >> On Oct 3, 2011, at 8:21 PM, NAKAMURA Takumi wrote: >> >>> FYI, diagtool list-warnings shows me; >>> >>> Warnings with flags (355): >>> (snip) >>> Warnings without flags (305): >>> (snip) >>> >>> STATISTICS: >>> >>> Percentage of warnings with flags: 53.79% >>> Number of unique flags: 168 >>> Average number of diagnostics per flag: 2.113 >>> >>> ******************** TEST 'Clang :: Misc/warning-flags.c' FAILED >>> ******************** >>> Script: >>> -- >>> diagtool list-warnings 2>&1 | FileCheck >>> /home/chapuni/bb/cmake-clang-x86_64-linux/llvm-project/clang/test/Misc/warning-flags.c >>> -- >>> Exit Code: 1 >>> Command Output (stderr): >>> -- >>> /home/chapuni/bb/cmake-clang-x86_64-linux/llvm-project/clang/test/Misc/warning-flags.c:20:8: >>> error: expected string not found in input >>> CHECK: Warnings without flags (304): >>> ^ >>> <stdin>:1:1: note: scanning from here >>> Warnings with flags (355): >>> ^ >>> -- >>> >>> ******************** >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
