On Thu, Oct 06, 2011 at 11:40:15AM -0500, John Criswell wrote: > Dear Clangers, > > I am submitting this small Makefile patch for review. It changes the > TableGen Makefile to specify its libraries using LINK_COMPONENTS instead > of USEDLIBS. > > The reason for the patch is that it allows Clang's TableGen utility to > be compiled within an LLVM sub-project without modification. Projects > such as SAFECode duplicate Clang's source inside an LLVM sub-project and > specialize it. This patch reduces the changes that such sub-projects > need to make to Clang to get it to compile within an LLVM sub-project. > > If approved, I can commit the change myself as I have commit access to > the LLVM SVN repository.
Does this still work with --enable-shared? We deliberately exclude TableGen from the shared library (since it defines top-level cl::opts), and it looks like LINK_COMPONENTS causes only the shared library to be linked to in --enable-shared mode. Perhaps LLVMLIBS is the variable that should be used here. Thanks, -- Peter _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
